-
Notifications
You must be signed in to change notification settings - Fork 128
Fixed the searchbar on focus #743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixed the searchbar on focus #743
Conversation
Signed-off-by: Aryan Shah <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@zihanKuang @vr-varad Can you please review this PR? |
.td-search__input.form-control:focus { | ||
color: inherit; | ||
background: transparent !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use !important
@ARYANSHAH1567
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vr-varad I tried for many options by removing the !important but later found that
There are some styling which are over-riding the current styles and it is being injected so its not from the code, i cant find any other option other than !important to override the injected styling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then you have to make sure these styles are top-level and should not be overwritten by other styles. @ARYANSHAH1567
Thank you for your contribution! Add it as an agenda item to the meeting minutes, if you would :) |
Notes for Reviewers
This PR fixes #740
The searchbar stays consistent even after focus also it doesnt get auto-focus now

Signed commits