Skip to content

Fixed the searchbar on focus #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ARYANSHAH1567
Copy link

Notes for Reviewers

This PR fixes #740

The searchbar stays consistent even after focus also it doesnt get auto-focus now
image

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Aug 5, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 9877a26
🔍 Latest deploy log https://app.netlify.com/projects/bejewelled-pegasus-b0ce81/deploys/6899a26b08e5f30008de55b6
😎 Deploy Preview https://deploy-preview-743--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ARYANSHAH1567
Copy link
Author

@zihanKuang @vr-varad Can you please review this PR?

.td-search__input.form-control:focus {
color: inherit;
background: transparent !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use !important @ARYANSHAH1567

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vr-varad I tried for many options by removing the !important but later found that
Screenshot 2025-08-07 200435
There are some styling which are over-riding the current styles and it is being injected so its not from the code, i cant find any other option other than !important to override the injected styling

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then you have to make sure these styles are top-level and should not be overwritten by other styles. @ARYANSHAH1567

@vr-varad
Copy link
Contributor

Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix searchBar
2 participants